feat: Add Loc support and Form component #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial commit of form public hoc
# Conflicts: # src/components/Dialog/BaseDialog/BaseDialog.tsx # src/components/RadioButton/radio.module.scss # src/components/Select/Select.tsx
# Conflicts: # src/components/Button/button.module.scss # src/components/Select/Select.tsx # src/components/Select/Select.types.ts # src/src/components/Navbar/__snapshots__/Navbar.stories.storyshot # src/src/components/Pagination/__snapshots__/Pagination.stories.storyshot # src/src/components/Select/__snapshots__/Select.stories.storyshot # src/src/components/Table/__snapshots__/Table.stories.storyshot # yarn.lock
removes unnecessary button prop updates tests and fixes other bugs
# Conflicts: # src/components/Button/BaseButton.tsx # src/components/Button/button.module.scss # src/components/Inputs/input.module.scss
dkilgore-eightfold
requested review from
ychhabra-eightfold and
jhoward-eightfold
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7a6628a:
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
=======================================
Coverage ? 89.43%
=======================================
Files ? 481
Lines ? 12988
Branches ? 4368
=======================================
Hits ? 11616
Misses ? 1347
Partials ? 25 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
# Conflicts: # src/components/DateTimePicker/Internal/ocpicker.module.scss # src/components/Dialog/BaseDialog/BaseDialog.tsx # src/components/Label/Label.types.ts # src/components/Select/Select.tsx # src/components/Select/Select.types.ts # src/components/Select/select.module.scss # src/src/components/Select/__snapshots__/Select.stories.storyshot # src/src/components/Table/__snapshots__/Table.stories.storyshot
cleans up datepicker and selector styles to match latest figma
renames some props and moves them to the types file
jhoward-eightfold
approved these changes
Sep 2, 2022
|
@dkilgore-eightfold Seems this PR is changing the radio sizes. This is breaking at multiple places across TA so reverting changes for radio label sizes in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Adds Form component, LocaleReceiver, LocaleProvider. Size, Validation, Disabled, and Shape contexts. Normalizes shapes, fixes a lot of CSS.
The video:
https://drive.google.com/file/d/1yGlmXsJnbHhgmfUN74IPYK5RZn9V72X6/view?usp=sharing
JIRA TASK (Eightfold Employees Only):
ENG-2792
ENG-2793
ENG-24252
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the pr branch and do
yarnandyarn storybook, verify all form stories.